Add route reflector client attribute to bgp neighbor resources

CiscoDevNet · Sep 13, 2023 · 54d1cba · 54d1cba
1 parent d1b92c8
commit 54d1cba
Show file tree

Hide file tree

Showing 21 changed files with 89 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 - Add support for leaf-lists to `iosxr_gnmi` resource
 - Add `port` and `operator` attributes to `iosxr_logging_vrf` resource and data source
 - Add `iosxr_router_hsrp_interface_address_family_ipv6_group_v2` resource and data source
+- Add `route_reflector_client` to `iosxr_router_bgp_neighbor_address_family` and `iosxr_router_bgp_neighbor_group` resource and data source
 
 ## 0.2.5
 

diff --git a/docs/data-sources/router_bgp_neighbor_address_family.md b/docs/data-sources/router_bgp_neighbor_address_family.md
@@ -40,4 +40,5 @@ data "iosxr_router_bgp_neighbor_address_family" "example" {
 - `id` (String) The path of the retrieved object.
 - `import_stitching_rt_re_originate_stitching_rt` (Boolean) Reoriginate imported routes by attaching stitching RTs
 - `next_hop_self_inheritance_disable` (Boolean) Prevent next-hop-self from being inherited from the parent
+- `route_reflector_client` (Boolean) Configure a neighbor as Route Reflector client
 - `route_reflector_client_inheritance_disable` (Boolean) Prevent route-reflector-client from being inherited from the parent
diff --git a/docs/data-sources/router_bgp_neighbor_group.md b/docs/data-sources/router_bgp_neighbor_group.md
@@ -54,5 +54,6 @@ Read-Only:
 
 - `af_name` (String) Enter Address Family command mode
 - `next_hop_self_inheritance_disable` (Boolean) Prevent next-hop-self from being inherited from the parent
+- `route_reflector_client` (Boolean) Configure a neighbor as Route Reflector client
 - `route_reflector_client_inheritance_disable` (Boolean) Prevent route-reflector-client from being inherited from the parent
 - `soft_reconfiguration_inbound_always` (Boolean) Always use soft reconfig, even if route refresh is supported
diff --git a/docs/guides/changelog.md b/docs/guides/changelog.md
@@ -13,6 +13,7 @@ description: |-
 - Add support for leaf-lists to `iosxr_gnmi` resource
 - Add `port` and `operator` attributes to `iosxr_logging_vrf` resource and data source
 - Add `iosxr_router_hsrp_interface_address_family_ipv6_group_v2` resource and data source
+- Add `route_reflector_client` to `iosxr_router_bgp_neighbor_address_family` and `iosxr_router_bgp_neighbor_group` resource and data source
 
 ## 0.2.5
 

diff --git a/docs/resources/router_bgp_neighbor_address_family.md b/docs/resources/router_bgp_neighbor_address_family.md
@@ -18,6 +18,7 @@ resource "iosxr_router_bgp_neighbor_address_family" "example" {
   neighbor_address                                          = "10.1.1.2"
   af_name                                                   = "vpnv4-unicast"
   import_stitching_rt_re_originate_stitching_rt             = true
+  route_reflector_client                                    = true
   route_reflector_client_inheritance_disable                = true
   advertise_vpnv4_unicast_enable_re_originated_stitching_rt = true
   next_hop_self_inheritance_disable                         = true
@@ -44,6 +45,7 @@ resource "iosxr_router_bgp_neighbor_address_family" "example" {
 - `encapsulation_type_srv6` (Boolean) SRv6 encapsulation
 - `import_stitching_rt_re_originate_stitching_rt` (Boolean) Reoriginate imported routes by attaching stitching RTs
 - `next_hop_self_inheritance_disable` (Boolean) Prevent next-hop-self from being inherited from the parent
+- `route_reflector_client` (Boolean) Configure a neighbor as Route Reflector client
 - `route_reflector_client_inheritance_disable` (Boolean) Prevent route-reflector-client from being inherited from the parent
 
 ### Read-Only

diff --git a/docs/resources/router_bgp_neighbor_group.md b/docs/resources/router_bgp_neighbor_group.md
@@ -29,6 +29,7 @@ resource "iosxr_router_bgp_neighbor_group" "example" {
       af_name                                    = "ipv4-labeled-unicast"
       soft_reconfiguration_inbound_always        = true
       next_hop_self_inheritance_disable          = true
+      route_reflector_client                     = true
       route_reflector_client_inheritance_disable = true
     }
   ]
@@ -80,6 +81,7 @@ Required:
 Optional:
 
 - `next_hop_self_inheritance_disable` (Boolean) Prevent next-hop-self from being inherited from the parent
+- `route_reflector_client` (Boolean) Configure a neighbor as Route Reflector client
 - `route_reflector_client_inheritance_disable` (Boolean) Prevent route-reflector-client from being inherited from the parent
 - `soft_reconfiguration_inbound_always` (Boolean) Always use soft reconfig, even if route refresh is supported
 

diff --git a/examples/resources/iosxr_router_bgp_neighbor_address_family/resource.tf b/examples/resources/iosxr_router_bgp_neighbor_address_family/resource.tf
@@ -3,6 +3,7 @@ resource "iosxr_router_bgp_neighbor_address_family" "example" {
   neighbor_address                                          = "10.1.1.2"
   af_name                                                   = "vpnv4-unicast"
   import_stitching_rt_re_originate_stitching_rt             = true
+  route_reflector_client                                    = true
   route_reflector_client_inheritance_disable                = true
   advertise_vpnv4_unicast_enable_re_originated_stitching_rt = true
   next_hop_self_inheritance_disable                         = true

diff --git a/examples/resources/iosxr_router_bgp_neighbor_group/resource.tf b/examples/resources/iosxr_router_bgp_neighbor_group/resource.tf
@@ -14,6 +14,7 @@ resource "iosxr_router_bgp_neighbor_group" "example" {
       af_name                                    = "ipv4-labeled-unicast"
       soft_reconfiguration_inbound_always        = true
       next_hop_self_inheritance_disable          = true
+      route_reflector_client                     = true
       route_reflector_client_inheritance_disable = true
     }
   ]

diff --git a/gen/definitions/router_bgp_neighbor_address_family.yaml b/gen/definitions/router_bgp_neighbor_address_family.yaml
@@ -11,6 +11,8 @@ attributes:
     example: vpnv4-unicast
   - yang_name: import/stitching-rt/re-originate/stitching-rt
     example: true
+  - yang_name: route-reflector-client
+    example: true
   - yang_name: route-reflector-client/inheritance-disable
     example: true
   - yang_name: advertise/vpnv4/unicast/enable/re-originated/stitching-rt

diff --git a/gen/definitions/router_bgp_neighbor_group.yaml b/gen/definitions/router_bgp_neighbor_group.yaml
@@ -49,6 +49,8 @@ attributes:
         example: true
       - yang_name: next-hop-self/inheritance-disable
         example: true
+      - yang_name: route-reflector-client
+        example: true
       - yang_name: route-reflector-client/inheritance-disable
         example: true
 

diff --git a/internal/provider/data_source_iosxr_router_bgp_neighbor_address_family.go b/internal/provider/data_source_iosxr_router_bgp_neighbor_address_family.go
diff --git a/internal/provider/data_source_iosxr_router_bgp_neighbor_address_family_test.go b/internal/provider/data_source_iosxr_router_bgp_neighbor_address_family_test.go
diff --git a/internal/provider/data_source_iosxr_router_bgp_neighbor_group.go b/internal/provider/data_source_iosxr_router_bgp_neighbor_group.go
diff --git a/internal/provider/data_source_iosxr_router_bgp_neighbor_group_test.go b/internal/provider/data_source_iosxr_router_bgp_neighbor_group_test.go
diff --git a/internal/provider/model_iosxr_router_bgp_neighbor_address_family.go b/internal/provider/model_iosxr_router_bgp_neighbor_address_family.go
diff --git a/internal/provider/model_iosxr_router_bgp_neighbor_group.go b/internal/provider/model_iosxr_router_bgp_neighbor_group.go
diff --git a/internal/provider/resource_iosxr_router_bgp_neighbor_address_family.go b/internal/provider/resource_iosxr_router_bgp_neighbor_address_family.go