added some missing yang references for router-bgp

[summed]

How about adding this? - Not sure what more is needed for this to be a eligible for a merge...

[danischm]

Many thanks for opening this PR! Did you have a chance to run the corresponding acceptance tests with your changes?

[summed]

@danischm

No particular reason for the version bump. That sort of happened by accident.

Tests: Some pass, while most seem to fail. Looks like some kind of timeout. One of many is here...

=== RUN   TestAccIosxrL2VPNPWClass
    resource_iosxr_l2vpn_pw_class_test.go:56: Step 1/3 error: Error running pre-apply refresh: exit status 1

        Error: Invalid provider configuration

        Provider "registry.terraform.io/hashicorp/iosxr" requires explicit
        configuration. Add a provider block to the root module and configure the
        provider's required arguments as described in the provider documentation.


        Error: Unable to create gNMI client

          with provider["registry.terraform.io/hashicorp/iosxr"],
          on <empty> line 0:
          (source code not available)

        Unable to create gNMI client:

        10.201.248.15:57400: context deadline exceeded
--- FAIL: TestAccIosxrL2VPNPWClass (10.50s)

[danischm]

Ok, in that case let's revert the change with the go version. I would not care about the other tests but only run the ones where you have modified the definition/code, for example:

go test -v ./... -run RouterBGPNeighborAddressFamily$

[shebang42]

@danischm

No particular reason for the version bump. That sort of happened by accident.

Tests: Some pass, while most seem to fail. Looks like some kind of timeout. One of many is here...

=== RUN   TestAccIosxrL2VPNPWClass
    resource_iosxr_l2vpn_pw_class_test.go:56: Step 1/3 error: Error running pre-apply refresh: exit status 1

        Error: Invalid provider configuration

        Provider "registry.terraform.io/hashicorp/iosxr" requires explicit
        configuration. Add a provider block to the root module and configure the
        provider's required arguments as described in the provider documentation.


        Error: Unable to create gNMI client

          with provider["registry.terraform.io/hashicorp/iosxr"],
          on <empty> line 0:
          (source code not available)

        Unable to create gNMI client:

        10.201.248.15:57400: context deadline exceeded
--- FAIL: TestAccIosxrL2VPNPWClass (10.50s)

Same here. Full output at https://gist.github.com/shebang42/e44b9c431e8c828edef91fa067f7e25a

[shebang42]

I also need these updated BGP resources. However, when using these, I noticed that timers_holdtime and timers_keepalive_interval are required parameters. Is this intentional?

https://github.com/summed/terraform-provider-iosxr/blob/main/docs/resources/router_bgp_neighbor_group.md