Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/router bgp #246

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

shebang42
Copy link
Contributor

add local_as* and description to iosxr_router_bgp_neighbor_group data-source and resource
add bgp_router_id and use_neighbor_group to iosxr_router_bgp_vrf data-source and resource

tests:

(base) ➜  ~/src/github/terraform-provider-iosxr git:(feature/router-bgp) ✗ 
> go test -v ./... -run RouterBGPVRF 
?       github.com/CiscoDevNet/terraform-provider-iosxr [no test files]
?       github.com/CiscoDevNet/terraform-provider-iosxr/internal/provider/client        [no test files]
?       github.com/CiscoDevNet/terraform-provider-iosxr/internal/provider/helpers       [no test files]
=== RUN   TestAccDataSourceIosxrRouterBGPVRFAddressFamily
--- PASS: TestAccDataSourceIosxrRouterBGPVRFAddressFamily (32.76s)
=== RUN   TestAccDataSourceIosxrRouterBGPVRFNeighborAddressFamily
--- PASS: TestAccDataSourceIosxrRouterBGPVRFNeighborAddressFamily (14.85s)
=== RUN   TestAccDataSourceIosxrRouterBGPVRF
--- PASS: TestAccDataSourceIosxrRouterBGPVRF (7.06s)
=== RUN   TestAccIosxrRouterBGPVRFAddressFamily
--- PASS: TestAccIosxrRouterBGPVRFAddressFamily (32.87s)
=== RUN   TestAccIosxrRouterBGPVRFNeighborAddressFamily
--- PASS: TestAccIosxrRouterBGPVRFNeighborAddressFamily (18.54s)
=== RUN   TestAccIosxrRouterBGPVRF
--- PASS: TestAccIosxrRouterBGPVRF (10.13s)
PASS
ok      github.com/CiscoDevNet/terraform-provider-iosxr/internal/provider       118.247s

@shebang42
Copy link
Contributor Author

Do you have an update if/when this can be merged? It will simplify our workflow if we can use the official binary, since we have to use a local binary for this provider in our pipeline.

@tomvrugt
Copy link

tomvrugt commented Jun 6, 2024

Do you have an update if/when this can be merged? It will simplify our workflow if we can use the official binary, since we have to use a local binary for this provider in our pipeline.

@danischm Can you please have a look at this PR?

@danischm danischm merged commit 211559e into CiscoDevNet:main Jun 6, 2024
3 checks passed
@tomvrugt
Copy link

tomvrugt commented Sep 3, 2024

@danischm can you please create a new release that contains this fix? Thanks!

@danischm
Copy link
Member

danischm commented Sep 3, 2024

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants