-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netconf custom verifier #102
Open
KacperSzmitko
wants to merge
3
commits into
CiscoTestAutomation:main
Choose a base branch
from
KacperSzmitko:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
from typing import List | ||
from typing import Any, List | ||
from dataclasses import field, dataclass | ||
from google.protobuf import json_format | ||
|
||
# Import base classes. For non pyats installation you can use class provided within this module | ||
try: | ||
from genie.libs.sdk.triggers.blitz.verifiers import GnmiDefaultVerifier | ||
from genie.libs.sdk.triggers.blitz.verifiers import GnmiDefaultVerifier, NetconfDefaultVerifier | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this or |
||
except ImportError: | ||
from yang.verifiers.base_verifier import BaseVerifier as GnmiDefaultVerifier | ||
|
||
|
||
class CountVerifier(GnmiDefaultVerifier): | ||
class GnmiCountVerifier(GnmiDefaultVerifier): | ||
from genie.libs.sdk.triggers.blitz.rpcverify import OptFields | ||
|
||
@dataclass | ||
class MyCustomReturns(OptFields): | ||
class CustomReturns(OptFields): | ||
''' | ||
Create a custom returns class to be used by the verifier | ||
by adding new fields to the default returns dataclass | ||
|
@@ -23,15 +23,15 @@ class MyCustomReturns(OptFields): | |
found_items: int = 0 | ||
|
||
@property | ||
def returns(self) -> List[MyCustomReturns]: | ||
def returns(self) -> List[CustomReturns]: | ||
return self._returns | ||
|
||
@returns.setter | ||
def returns(self, value: List[dict]) -> List[MyCustomReturns]: | ||
def returns(self, value: List[dict]) -> List[CustomReturns]: | ||
''' | ||
Register our custom returns class | ||
''' | ||
self._returns = [self.MyCustomReturns(**r) for r in value] | ||
self._returns = [self.CustomReturns(**r) for r in value] | ||
|
||
def decode(self, response, namespace: dict = None, method: str = 'get') -> List[dict]: | ||
from genie.libs.sdk.triggers.blitz.gnmi_util import GnmiMessage | ||
|
@@ -61,6 +61,50 @@ def end_subscription(self, errors): | |
if errors: | ||
return False | ||
for ret in self.returns: | ||
if ret.count != ret.found_items or ret.found_items < self.kwargs['min_count']: | ||
if (ret.count != ret.found_items or | ||
ret.found_items < self.format['verifier']['min_count']): | ||
return False | ||
return True | ||
|
||
|
||
class NetconfCountVerifier(NetconfDefaultVerifier): | ||
from genie.libs.sdk.triggers.blitz.rpcverify import OptFields | ||
|
||
@dataclass | ||
class CustomReturns(OptFields): | ||
''' | ||
Create a custom returns class to be used by the verifier | ||
by adding new fields to the default returns dataclass | ||
''' | ||
cli_return: dict = field(default_factory=dict) | ||
count: int = 0 | ||
found_items: int = 0 | ||
|
||
@property | ||
def returns(self) -> List[CustomReturns]: | ||
return self._returns | ||
|
||
@returns.setter | ||
def returns(self, value: List[dict]) -> List[CustomReturns]: | ||
''' | ||
Register our custom returns class | ||
''' | ||
self._returns = [self.CustomReturns(**r) for r in value] | ||
|
||
def get_config_verify(self, raw_response: Any) -> bool: | ||
# Here we have raw netconf xml response | ||
# We are decoding it using default netconf decoder | ||
# but you can use your own decode method | ||
try: | ||
decoded_response = self.decode(raw_response) | ||
except self.DecodeError: | ||
return False | ||
for response in decoded_response: | ||
for ret in self.returns: | ||
if response[1] == ret.xpath: | ||
ret.found_items += 1 | ||
for ret in self.returns: | ||
if (ret.count != ret.found_items or | ||
ret.found_items < self.format['verifier']['min_count']): | ||
return False | ||
return True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this removed intentionally? Seems strange to just get rid of it