Lamps separated into on and off, Library lamps start on and Mining Gateway Medikits aren't empty #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
|
I'd also repair the one line thing on the R-UST but I feel like that'd break the scope |
silicons
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes lamps actually start on and replaces the empty medikits in surt gateway on both atlas and triumph
Why It's Good For The Game
The library on the Atlas has always been super dim, and yet the lamps were obviously coded to be on. Something wasn't working, I guess this fixes it, and separates them into an on and off definition. As for the surt gateway medikits, it makes no sense to place down empty ones, rather remove them entirely.
Changelog
adds on state for both lamp types, replaces empty medikits with regular medikits on atlas and triumph
🆑
add: Added /obj/item/flashlight/lamp/on
add: Added /obj/item/flashlight/lamp/green/on
tweak: tweaked /obj/item/flashlight initialize proc
/:cl: