Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Replaces scrapy-sentry with a new custom built package called scrapy-sentry-errors.
Why are we doing this?
scrapy-sentry worked great for City Bureau's city-scraper repos for many years but it appears to no longer be maintained. The package uses older dependencies and python packaging processes that were increasingly causing unexpected conflicts with dependencies in city-scraper repos, including this one, meaning our CI process couldn't run.
This PR replaces scrapy-sentry with scrapy-sentry-errors – built by City Bureau – that uses modern python packaging practices and upgraded dependencies. Longterm, using our own sentry integration lets us better tailor sentry monitoring to our specific needs.
Steps to manually test
It's critical that our Sentry monitoring continues to work as expected. Locally, you can ensure Sentry monitoring is working correctly by doing the following:
city_scrapers/settings/base.py
and add the following key and the DSN as its value:cuya_administrative_rules
spider is a good choice. Execute with this command:Are there any smells or added technical debt to note?