Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spider: cuya_board_control #82

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

haileyhoyat
Copy link
Contributor

What's this PR do?
Fixes our Cuyahoga County Board of Control spider (aka. cuya_control_board), which broke due to URL and page structure changes across Cuyahoga County's website.

Why are we doing this?
To ensure our Cuyahoga County Board of Control spider works. The changes in this PR include use of a new class mixin for scraping the Cuyahoga County website.

Steps to manually test
Clone this repo, run the command: cd city_scrapers && scrapy crawl cuya_board_control

Are there any smells or added technical debt to note?
No

@skorasaurus
Copy link
Collaborator

fixes #7 =)

@haileyhoyat
Copy link
Contributor Author

Oh FYI:

Will (@skorasaurus ), I don't know if you've heard that City Bureau has a new in-house developer Dan ( @SimmonsRitchie ).

Dan, this is Will, he's the guy who led the initial Cleveland city scrapers build. He works as a web developer for our Cleveland Public Library.

Will, this is Dan. He's the new in-house City Scrapers developer where he's taking charge of the City Scrapers project. So if you him making changes in the repos don't be alarmed, he's one of us.

@skorasaurus
Copy link
Collaborator

Oh FYI:

Will (@skorasaurus ), I don't know if you've heard that City Bureau has a new in-house developer Dan ( @SimmonsRitchie ).

Dan, this is Will, he's the guy who led the initial Cleveland city scrapers build. He works as a web developer for our Cleveland Public Library.

Will, this is Dan. He's the new in-house City Scrapers developer where he's taking charge of the City Scrapers project. So if you him making changes in the repos don't be alarmed, he's one of us.

thanks for all of your contributions so far Dan! @SimmonsRitchie
@pjsier was the lead architect on the city scrapers and deserves far more credit than I do.

@SimmonsRitchie
Copy link
Contributor

Thank you for the intro, @haileyhoyat, and you thank you for the kudos, @skorasaurus! I truly appreciate your own contributions to the city-scrapers project (and of course, to @pjsier too).

Copy link
Contributor

@SimmonsRitchie SimmonsRitchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @haileyhoyat! Code looks clean. Rewritten spider works well. Tests pass. Let's ship it 🚢 🚢🚢

@haileyhoyat haileyhoyat merged commit c48a17a into City-Bureau:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants