🕷️ Fix spider: Board of Estimate and Taxation #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Includes meetings from one month ago with the final meeting payload.
Why are we doing this?
This is an attempt to fix a potential bug reported by our Minn site partners. Apparently sometimes meetings show up as "cancelled" when they're not cancelled. Based on my testing, it seems like our scraper is working correctly (we derive cancellation status directly from the
Cancelled
field in the city's meeting API). My best guess at the moment is that perhaps we're not capturing last minute changes to meeting statuses by the city. We're currently requesting meetings from today and onwards. Perhaps by requesting meetings from 30 days before day and onwards, we'll capture better data.Steps to manually test
After installing the project using
pipenv
:Monitor the stdout and ensure that the crawl proceeds without raising any errors. Pay attention to the final status report from scrapy.
Inspect
test_output.csv
to ensure the data looks valid. I suggest opening a few of the URLs under the source column of test_output.csv and comparing the data for the row with what you see on the page.Are there any smells or added technical debt to note?