Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Clean up CI, deps, readme, and misc items #10

Merged
merged 13 commits into from
Feb 5, 2024
Merged

Conversation

SimmonsRitchie
Copy link
Contributor

@SimmonsRitchie SimmonsRitchie commented Feb 5, 2024

What's this PR do?

An omnibus PR that modifies the repo in a number of way:

  • Deletes unused dependencies
  • Enables dep caching in CI workflow
  • Ensure if pytest finds no tests, CI test will still pass
  • Sets pipenv env to Python 3.9
  • Configures scrapy-sentry-errors
  • Adds keepalive workflow to prevent github workflow deactivation
  • Updates PR template
  • Updates readme
  • Rebuilds pipenv.lock
  • Removes commented out code in settings and workflows
  • Enables logs when deploy.sh is run

Why are we doing this?

These updates are needed across most of the city-scraper repos in order to ensure they run smoothly and they don't include dead code that may confuse contributors.

Steps to manually test

N/A

Are there any smells or added technical debt to note?

@SimmonsRitchie SimmonsRitchie marked this pull request as ready for review February 5, 2024 22:02
@SimmonsRitchie SimmonsRitchie merged commit 79b46d7 into main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant