changed deleteRow method to use Upsert and added a helper class (Payl… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build SODA.NET 0.10.1-111-dsdieqgw completed (commit b24265ad07 by @) |
1 similar comment
|
✅ Build SODA.NET 0.10.1-111-dsdieqgw completed (commit b24265ad07 by @) |
|
@thekaveman this will fix issue #85 that my organisation has been hitting. It would be great if this could be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the existing deleterow method to basically redirect to the sodaclient.Upsert method. It still takes the same parameters and returns a SodaResult.
I added another DeleteRow method that takes a list if RowId's so can do a bulk delete now. I called it DeleteRow also, to keep the changes to a minimum, not sure if better to call it DeleteRows?
I also added a helper class into Utilities "Payloadbuilder.cs" which just takes the RowId('s) and constructs into the required json format.
I didnt add any tests, not sure if any needed, and also i'm not very familiar with test frameworks.
I wrote the same logic into my application and has been working fine. See what you think
Thanks
Mick