-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle boilerplate #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions. Overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further thought, I really don't like the introduction of the Architectory API dependency. We don't use any of its features (it seems more geared towards modifying the base game by adding blocks etc.) and it requires users installing another jar.
I'm happy to remove the Architectury API, but I would like some brainstorming on how we can assert that a development environment is a development environment. Spamming Mojang with authentication requests is not great. |
Is the disable auth option not sufficient, also I was under the impression you wanted to use architectury for its other features too. |
Nope. The server sends the Your |
c66a790
to
37deaf0
Compare
- Moves the Mojang mappings to the subprojects block in the root build.gradle. - Updates the "dev.architectury.loom" plugin to 0.12.0-SNAPSHOT. - Updates "com.github.johnrengelman.shadow" plugin to 7.1.2. - Updates the Fabric Loader version from 0.13.3 to 0.14.9. - Updates the Fabric API version from 0.51.1 to 0.58.0. - Updates the Forge version from 40.1.19 to 40.1.73.
37deaf0
to
8d519ea
Compare
Moves the Mojang mappings to the subprojects block in the root build.gradle.
Updates the "dev.architectury.loom" plugin to 0.12.0-SNAPSHOT.
Updates "com.github.johnrengelman.shadow" plugin to 7.1.2.
Updates the Fabric Loader version from 0.13.3 to 0.14.9.
Updates the Fabric API version from 0.51.1 to 0.58.0.
Updates the Forge version from 40.1.19 to 40.1.73.