Fix changing of label while selection and duplicate creation for exis…

…ting items in combobox creatable
CivicDataLab · Oct 15, 2024 · 60b3910 · 60b3910
1 parent efdec0b
commit 60b3910
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/packages/opub-ui/src/components/Combobox/Combobox.tsx b/packages/opub-ui/src/components/Combobox/Combobox.tsx
@@ -190,22 +190,12 @@ export const Combobox = React.forwardRef(
 
           // for multi select
           const selectedArr = e.map((value: string) => {
-            if (comboboxList.findIndex((item) => item.value === value) > 0) {
-              return comboboxList.find((item) => item.value === value);
-            } else {
-              setComboboxList([
-                ...comboboxList,
-                {
-                  label: value,
-                  value: value,
-                },
-              ]);
-
-              return {
+            return (
+              comboboxList.find((item) => item.value === value) || {
                 label: value,
                 value: value,
-              };
-            }
+              }
+            );
           });
 
           setSelectedValues(selectedArr);