Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent initialize git submodules #8

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Prevent initialize git submodules #8

wants to merge 11 commits into from

Conversation

ClausKlein
Copy link
Owner

aminya/project_options has an example as submodule this is not needed while build

@ClausKlein ClausKlein requested a review from johlhll August 3, 2023 11:23
papperlapapp
papperlapapp reviewed Aug 12, 2023
View reviewed changes
ClausKlein and others added 9 commits December 11, 2024 06:06
@ClausKlein
Prevent initialize git submodules
bfe518b 
aminya/project_options has an example as submodule
this is not needed while build
@ClausKlein
Change cmake workflow presets a bit
2421ee4 
To reduce the buildtime, install doctest while test installed version
at test subdirectory.
@ClausKlein
Prevent cmake warnings
31d6633
@ClausKlein
Use workaround for GIT_SUBMODULES
6dfd9cc
@ClausKlein
Fix CI build again
66db293
@ClausKlein @papperlapapp
Update cmake/options.cmake
82c8507 
Co-authored-by: papperlapapp <papperlapapp@users.noreply.github.com>
@ClausKlein
Set CMAKE_DEPFILE_FLAGS_CXX
ae7c934
@ClausKlein
Fix CMAKE_DEPFILE_FLAGS_CXX setup
8c3b2ee
@ClausKlein
make format
454f887
@ClausKlein ClausKlein force-pushed the feature/prevent-git-submodules-init branch from e43fd9e to 454f887 Compare December 11, 2024 05:12
johlhll
johlhll reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@johlhll johlhll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not check every detail, cmake running ok,
however, some minor flaws from compiler checks (stronger rules as before?)

@ClausKlein ClausKlein requested a review from johlhll December 13, 2024 09:48
johlhll
johlhll approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@johlhll johlhll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider NOLINT [bugprone-exception-escape] to eliminate the last warning in main (line 10)

@ClausKlein
Copy link
Owner Author

consider NOLINT [bugprone-exception-escape] to eliminate the last warning in main (line 10)

My intention is to show, how clang-tidy works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlhll johlhll johlhll approved these changes

@papperlapapp papperlapapp Awaiting requested review from papperlapapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClausKlein @papperlapapp @johlhll