Feature/use cmake init #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
commented
Apr 3, 2022
ClausKlein
commented
Apr 3, 2022
ClausKlein
commented
Apr 3, 2022
ClausKlein
commented
Apr 3, 2022
ClausKlein
commented
Apr 3, 2022
friendlyanon
suggested changes
Apr 6, 2022
There was a problem hiding this comment.
It looks like your mentions somehow got messed up, as they are not really mentions.
I commented on some of the things, but the one thing that is of utmost importance is to not have the developer mode be enabled by default. The reason for this is explained in the HACKING document. Contrast that with the BUILDING document, which is the user facing document and is assumed to be the default case.
ClausKlein
force-pushed
the
feature/use-cmake-init
branch
from
766073f to
e52efbb
Compare
ClausKlein
commented
Aug 7, 2022
ClausKlein
commented
Aug 7, 2022
ClausKlein
force-pushed
the
feature/use-cmake-init
branch
from
191d8f7 to
fc13db5
Compare
asio needs Threads library, so this is added to install-config.cmake export ASIO_NO_DEPRECATED definition add cmake user preset too do not convert british to american english add todos from codespell check liberate clang-tidy config file for use with async code too use cmake VERIFY_INTERFACE_HEADER_SETS install pkg config file too suppress compiler Warnings with llvm-17 on OSX do not verify nor install experimental headers disalbe some warnings in developer mode
ClausKlein
force-pushed
the
feature/use-cmake-init
branch
2 times, most recently
from
94e37bc to
3893e8e
Compare
Add requirements.txt for pip Add ignore-workd-list for codespell Add CI cmake based project workflow
ClausKlein
force-pushed
the
feature/use-cmake-init
branch
from
5f7f60d to
b559809
Compare
Update used tools versions on CI build
ClausKlein
force-pushed
the
feature/use-cmake-init
branch
from
f6bfdc0 to
a863ad5
Compare
|
Old asio source code version not longer supported! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.