Compat for SIGQUIT

src/mirakuru/compat.py

@@ -21,5 +21,8 @@
 # Windows does not have SIGKILL, fall back to SIGTERM.
 SIGKILL = getattr(signal, "SIGKILL", signal.SIGTERM)
 
+# Windows does not have SIGQUIT, fall back to SIGTERM.
+SIGQUIT = getattr(signal, "SIGQUIT", signal.SIGTERM)
+
 
 __all__ = ("SIGKILL",)

tests/executors/test_executor.py

@@ -2,7 +2,6 @@
 """Test basic executor functionality."""
 import gc
 import shlex
-import signal
 from subprocess import check_output
 import uuid
 from unittest import mock
@@ -11,6 +10,7 @@
 
 from mirakuru import Executor
 from mirakuru.base import SimpleExecutor
+from mirakuru.compat import SIGQUIT
 from mirakuru.exceptions import ProcessExitedWithError, TimeoutExpired
 
 from tests import SAMPLE_DAEMON_PATH, ps_aux
@@ -44,7 +44,7 @@ def test_command(command):
 
 def test_custom_signal_stop():
     """Start process and shuts it down using signal SIGQUIT."""
-    executor = SimpleExecutor(SLEEP_300, sig_stop=signal.SIGQUIT)
+    executor = SimpleExecutor(SLEEP_300, sig_stop=SIGQUIT)
     executor.start()
     assert executor.running() is True
     executor.stop()
@@ -56,7 +56,7 @@ def test_stop_custom_signal_stop():
     executor = SimpleExecutor(SLEEP_300)
     executor.start()
     assert executor.running() is True
-    executor.stop(sig=signal.SIGQUIT)
+    executor.stop(sig=SIGQUIT)
     assert executor.running() is False
 
 
@@ -65,14 +65,14 @@ def test_stop_custom_exit_signal_stop():
     executor = SimpleExecutor("false", shell=True)
     executor.start()
     # false exits instant, so there should not be a process to stop
-    retry(lambda: executor.stop(sig=signal.SIGQUIT, exp_sig=3))
+    retry(lambda: executor.stop(sig=SIGQUIT, exp_sig=3))
     assert executor.running() is False
 
 
 def test_stop_custom_exit_signal_context():
     """Start process and expect custom exit signal in context manager."""
     with SimpleExecutor("false", exp_sig=3, shell=True) as executor:
-        executor.stop(sig=signal.SIGQUIT)
+        executor.stop(sig=SIGQUIT)
         assert executor.running() is False
 
 

tests/executors/test_executor_kill.py

@@ -1,19 +1,16 @@
 # mypy: no-strict-optional
 """Tests that check various kill behaviours."""
-import signal
 import time
 import sys
 
 import errno
 
-import os
 from unittest.mock import patch
 
-import psutil
 import pytest
 
 from mirakuru import SimpleExecutor, HTTPExecutor
-from mirakuru.compat import SIGKILL
+from mirakuru.compat import SIGKILL, SIGQUIT
 from mirakuru.exceptions import ProcessFinishedWithError
 from mirakuru.kill import killpg
 
@@ -24,7 +21,7 @@
 
 def test_custom_signal_kill():
     """Start process and shuts it down using signal SIGQUIT."""
-    executor = SimpleExecutor(SLEEP_300, sig_kill=signal.SIGQUIT)
+    executor = SimpleExecutor(SLEEP_300, sig_kill=SIGQUIT)
     executor.start()
     assert executor.running() is True
     executor.kill()
@@ -36,7 +33,7 @@ def test_kill_custom_signal_kill():
     executor = SimpleExecutor(SLEEP_300)
     executor.start()
     assert executor.running() is True
-    executor.kill(sig=signal.SIGQUIT)
+    executor.kill(sig=SIGQUIT)
     assert executor.running() is False