feat/MSSDK-1748: Remove redux-mock-store and redux-thunk packages #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saddage
reviewed
Oct 18, 2024
There was a problem hiding this comment.
IMHO it is better to use renderWithProviders from src/util/testHelpers.tsx. you can make the change only once there and then reuse it across the tests.
Also, please find the usages of <Provider in tests and also replace them with the renderWithProviders. This will improve our testing codebase. Thanks!
…tionHandler to TS
…tionHandler to TS
|
|
@m4tewoosh , please rename the PR and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
redux-mock-storeandredux-thunk packagesare used only in the unit tests. However, what they offer is already provided by the@reduxjs/toolkitpackage that we use.Updates
Used
configureStorefrom@reduxjs/toolkitinstead of the one fromredux-mock-storeand removed both packages