added verification for assert #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this is better |
ClementWalter
previously approved these changes
May 22, 2024
ClementWalter
previously approved these changes
May 23, 2024
ClementWalter
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title [TO BE UPDATED]
Time spent on this PR: 2 hours.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently there is no check whether an assert is valid.
Resolves #6
What is the new behavior?
Now an AssertEqError is raised when asserts are not valid (in AssertEq and Call opcodes).