-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bitwise builtins #21
Merged
ClementWalter
merged 7 commits into
ClementWalter:main
from
KeneePatel:feat/add_bitwise_builtins
Jun 3, 2024
Merged
feat: add bitwise builtins #21
ClementWalter
merged 7 commits into
ClementWalter:main
from
KeneePatel:feat/add_bitwise_builtins
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've updated the repo to organizz things a bit better. Can you
|
ClementWalter
requested changes
Jun 3, 2024
ClementWalter
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added bitwise builtins
Time spent on this PR: 30 mins
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
No builtin functions for bitwise operations.
Resolves #20
What is the new behavior?
Added four functions:
All functions take two inputs of a bigint and outputs a bigint as well.
The first three functions do what they are expected to, and the last function returns output of all three other functions wrapped in an array.