Skip to content

Update dependencies #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependencies #290

wants to merge 1 commit into from

Conversation

prime-time
Copy link
Contributor

Overview:
react-onclickoutside was included here as part of a temporary fix: #176

And the temp fix was reverted here: #276
but I forgot to remove it as a dependency.

Testing:

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE10

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change? Run npm version minor
      • Backward compatible change? Run npm version patch
      • Only changing documentation? All good. Skip this step.
  • After merging:
    • Deployed updated docs (make deploy-docs)

@alsmola alsmola force-pushed the update-dependencies branch from 12faaac to d7ead4b Compare November 13, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prime-time