Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE File Vars] Updated file expiry logic #350

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

nishant-clevertap
Copy link
Contributor

  • The file expiry timestamp were not getting updated for PE File vars if file was already present because we were only updating the expiry timestamp when downloadFiles: is called. For InApps downloadFiles: are called for all urls, but for PE File Var we are calling it for urls which are not present.
  • The expired files were not getting deleted if we don't call downloadFiles: anywhere. So added logic to check for expired files and delete them when CTFileDownloader is initialised only, ie on every App launch.

…ars.

- Fixes expired files were not deleted when downloadFiles is not called.
Copy link
Contributor

@nzagorchev nzagorchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nishant-clevertap nishant-clevertap merged commit ed9e4d3 into develop Jul 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants