SDK-4010 - onUserLogin for iOS appends user string prefix to both Email and Name system user properties #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleverTapSDK/CTUserInfoMigrator.m
Outdated
|
|
||
| // Iterate through the original dictionary's keys | ||
| for (NSString *key in [dictionary allKeys]) { | ||
| if ([knownProfileFields containsObject:key] && [key hasPrefix:@"user"]) { |
There was a problem hiding this comment.
I think the first condition should be enough maybe.
akashvercetti
changed the title
akashvercetti
changed the title
nzagorchev
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Please, check the comments left.
I believe the code which maps the keys becomes redundant now (CTProfileBuilder):
KnownField kf = [CTKnownProfileFields getKnownFieldIfPossibleForKey:key];
if (kf != UNKNOWN) {
// This will return the same key
systemFields[[CTKnownProfileFields getStorageValueForField:kf]] = value;
Please, also address the following:
- Fix
CTUserInfoMigratorTesttests - Add a
CTUserInfoMigratorTesttest for the new migration logic - Add a
CTProfileBuilder:build:completionHandlerfor profile test if possible - Add a
CTLocalDataStore:generateBaseProfiletest if possible
CleverTapSDK/CTUserInfoMigrator.m
Outdated
|
|
||
| @implementation CTUserInfoMigrator | ||
|
|
||
| + (void)migrateUserInfoFileForAccountID:(NSString *)acc_id deviceID:(NSString *)device_id { | ||
| + (void)migrateUserInfoFileForAccountID:(NSString *)acc_id deviceID:(NSString *)device_id config:(CleverTapInstanceConfig *) config { |
There was a problem hiding this comment.
Since you pass the whole CleverTapInstanceConfig instance, you can read the accountId from the config, instead of passing it as another parameter.
CleverTapSDK/CTUserInfoMigrator.h
Outdated
|
|
||
| @interface CTUserInfoMigrator : NSObject | ||
|
|
||
| + (void)migrateUserInfoFileForAccountID:(NSString *)acc_id deviceID:(NSString *)device_id; | ||
| + (void)migrateUserInfoFileForAccountID:(NSString *)acc_id deviceID:(NSString *)device_id config:(CleverTapInstanceConfig *) config; |
There was a problem hiding this comment.
This change breaks the CTUserInfoMigratorTest tests, please see the other comment about this method parameters and address the tests, as well.
nzagorchev
approved these changes
Aug 22, 2024
akashvercetti
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
@kushCT add version and changelog changes here or in another branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Userprefix getting appended to system variables