Feature_MC-1970 #88
Open
Feature_MC-1970 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzagorchev
requested changes
Oct 3, 2024
| using CleverTapSDK.Utilities; | ||
|
|
||
| #if (!UNITY_IOS && !UNITY_ANDROID) || UNITY_EDITOR | ||
| namespace Native.UnityNativeWrapper |
There was a problem hiding this comment.
Fix namespace to be CleverTapSDK.Native and remove it from the usings.
| #if (!UNITY_IOS && !UNITY_ANDROID) || UNITY_EDITOR | ||
| namespace Native.UnityNativeWrapper | ||
| { | ||
| internal class UnityNativeMetadataResponseInterceptor : IUnityNativeResponseInterceptor |
There was a problem hiding this comment.
The response interceptor is unused, it is not added to the engine interceptors.
There was a problem hiding this comment.
I believe it is better for the interceptor to not have a reference to the network engine. This creates a circular reference since the engine adds and holds the interceptors.
The options on top of my head are:
- The interceptor to set the
_iand_jin the preferences and the engine to use them from there. The interceptor can get the preference manager using the account id. - Do this logic directly in the network engine.
I believe it might be cleaner to go with 1. since you also already started with that approach.
| _networkEngine.SetI(i); | ||
| } | ||
| } catch (Exception t) { | ||
| // Ignore |
There was a problem hiding this comment.
Do not ignore the exception.
| _networkEngine.SetJ(j); | ||
| } | ||
| } catch (Exception t) { | ||
| // Ignore |
There was a problem hiding this comment.
Do not ignore the exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented _i and _j functionality