Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ClimaTimeSteppers #1401

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Use ClimaTimeSteppers #1401

merged 1 commit into from
Aug 1, 2023

Conversation

charleskawczynski
Copy link
Member

This is a peel off from #1358.

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 31, 2023
@bors
Try #1401:
8433f5e
@bors
Copy link
Contributor

bors bot commented Jul 31, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 31, 2023
@bors
Try #1401:
ee352fe
@bors
Copy link
Contributor

bors bot commented Jul 31, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 31, 2023
@bors
Try #1401:
db1d58d
@bors
Copy link
Contributor

bors bot commented Jul 31, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 31, 2023
@bors
Try #1401:
cbbd634
@charleskawczynski
Copy link
Member Author

The IGW fails at dt = is_small_scale ? FT(0.2) : FT(20)

@bors
Copy link
Contributor

bors bot commented Jul 31, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 1, 2023
@bors
Try #1401:
79d4442
@bors
Copy link
Contributor

bors bot commented Aug 1, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@charleskawczynski
Use ClimaTimeSteppers
f0941a0 
try SSP333

Use SSP333
@charleskawczynski
Copy link
Member Author

Switching from OrdinaryDiffEq's Rosenbrock23 to ClimaTimesteppers ARS343 resulted in several simulations having NaNs at the end of the simulation. The inertial gravity wave problem required changing the timestep from dt = 1.5 to dt = 0.1 to be stable. @dennisYatunin suggested trying SSP333, which was stable for the IGW. So, I'm switching all of the examples that used Rosenbrock to use SSP333 (we don't have Rosenbrock in ClimaTimesteppers).

If I don't see NaNs, I'm going to go ahead and merge this in hopes that it will help us push forward with #1235.

@charleskawczynski
Copy link
Member Author

btw, it's a bit discomforting that all of our examples pass with NaNs in the result (cc @simonbyrne), maybe we can throw an error instead?

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 1, 2023
@bors
Try #1401:
801bf18
@charleskawczynski
Copy link
Member Author

Ok, I reviewed some of the solutions with SSP333, and they look okay.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 1, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors
Copy link
Contributor

bors bot commented Aug 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f84433c into main Aug 1, 2023
5 checks passed
@bors bors bot deleted the ck/deps2 branch August 1, 2023 07:48
@charleskawczynski charleskawczynski mentioned this pull request Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski