-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HF datalayouts #2055
Open
charleskawczynski
wants to merge
14
commits into
main
Choose a base branch
from
ck/HF_datalayouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add HF datalayouts #2055
+2,301
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/HF_datalayouts
branch
9 times, most recently
from
October 22, 2024 18:33
abab1a8
to
9ba4a0d
Compare
charleskawczynski
force-pushed
the
ck/HF_datalayouts
branch
from
October 23, 2024 01:50
9ba4a0d
to
3bed155
Compare
charleskawczynski
requested review from
dennisYatunin,
Sbozzolo and
sriharshakandala
October 23, 2024 19:59
cc @sriharshakandala, @dennisYatunin, @Sbozzolo, this PR may not be completely ready as I'm ironing out some issues, but can you please review the extension of our datalayouts and the design of how I've added the ability to make HF spaces? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for new datalayouts:
VIJHF
IJHF
IHF
VIHF
For these new datalayouts, and other datalayouts that end with the field index, we'll be able to add fast paths for linear indexing. This will simply involve reviving #1922, and specializing on all datalayouts with the field index at the end.
Finally, we can compare this with our
VIJFH
datalayout performance.To make this work with our existing implementation, users can now make horizontal spaces with a new keyword argument:
HorizontalLayout = DataLayouts.IJFH
, which users may change toHorizontalLayout = DataLayouts.IJHF
to try the new datalayout.