Use higher resolution land-sea mask #1006
Conversation
Sbozzolo
force-pushed
the
gb/landsea
branch
3 times, most recently
from
1ec7ea0
to
6ac91fd
Compare
|
We can either try using this and see if there is a problem (with our resolution I guess probably not), or use the one @akshaysridhar referenced here, which is already better than what we have now. |
Yeah this reference is in part based on the current |
This PR uses the topography artifact. Could you either check if this is ok, or add the higher resolution land sea mask to ClimaArtifact and update it in the coupler? |
Sbozzolo
force-pushed
the
gb/landsea
branch
2 times, most recently
from
e63816d
to
42c98fa
Compare
Sbozzolo
force-pushed
the
gb/landsea
branch
9 times, most recently
from
2e64625
to
c4ac880
Compare
As added in CliMA/ClimaArtifacts#49 60 arcseconds is already pretty high resolution
The only artifact that might be needed is ETOPO for ClimaAtmos, but that should go away soon
|
I updated this PR to remove ArtifactWrappers and all the artifact infrastructure. I think this can only be merged after CliMA/ClimaAtmos.jl#3378 |
| by identifying where elevation is greater than 0. Note, this can lead to | ||
| misidentification of ocean in some areas of the globe that are inland but below | ||
| sea level (Dead Sea, Death Valley, ...). |
There was a problem hiding this comment.
Do we have a plan to correct this ocean misidentification in the future?
| @@ -1,8 +1,8 @@ | |||
| # This file is machine-generated - editing it directly is not advised | |||
|
|
|||
| julia_version = "1.11.1" | |||
There was a problem hiding this comment.
Maybe we want to stay at 1.11.1 unless there's a reason to go back to 1.11.0
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| julia_version = "1.10.5" | |||
There was a problem hiding this comment.
we should update perf/Manifest-v1.11.toml as well
As added in CliMA/ClimaArtifacts#49
30 arcseconds is already pretty high resolution
Closes #936
Closes #730
Closes #1016
This PR also removes all the artifact infrastructure from ClimaCoupler.