Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Diagnostics module #953

Merged
merged 3 commits into from
Oct 16, 2024
Merged

remove Diagnostics module #953

merged 3 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. extend make_ci_plots for amip paperplots

    This generalizes the `make_ci_plots` function to `make_plots`
    which takes in variable names as an argument instead of
    hardcoding them within the function
    juliasloan25 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8b9f806 View commit details
    Browse the repository at this point in the history
  2. use ClimaDiagnostics for AMIP diags

    The ClimaCoupler Diagnostics module had become redundant with
    ClimaDiagnostics.jl, a package designed to provide robust
    diagnostics across the CliMA ecosystem.
    Here we remove ClimaCoupler.Diagnostics and instead use
    ClimaDiagnostics.
    
    We're able to retrive most of the diagnostics
    we want directly from ClimaAtmos and ClimaLand, but also want
    some that come from coupler-computed quantities, such as
    `F_turb_energy`. In this PR we add this coupler quantity
    to our output diagnostics using the ClimaDiagnostics interface.
    
    This PR also removes the AMIP paperplots function, but this
    functionality is replaced by the generalized `make_plots` function.
    juliasloan25 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a44f9e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e4bbc30 View commit details
    Browse the repository at this point in the history