-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SoilCO2ModelParameters
constructor
#504
Conversation
6e9eb07
to
d53cdc8
Compare
Our soilCO2 model is a combination of these two papers: |
Thank you @AlexisRenchon ! |
d53cdc8
to
eab438a
Compare
eb3857b
to
123a1cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nat,
The PR looks good... is there anything in particular I should look at?
Are these defaults correct? |
Yes the defaults are correct! |
8c6cb46
to
ba6dc2e
Compare
This PR uses ClimaParams for
SoilCO2ModelParameters
.As before, the new constructors are: