Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SoilCO2ModelParameters constructor #504

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Feb 17, 2024

This PR uses ClimaParams for SoilCO2ModelParameters.

As before, the new constructors are:

import ClimaLand
import ClimaParams as CP
toml_dict= CP.create_toml_dict(Float32)

ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(Float64)
ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(Float64; ν = 99999)
ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(toml_dict)
ClimaLand.Soil.Biogeochemistry.SoilCO2ModelParameters(toml_dict; ν = 99999)

@nefrathenrici nefrathenrici force-pushed the ne/soilco2_params branch 2 times, most recently from 6e9eb07 to d53cdc8 Compare February 29, 2024 21:55
@AlexisRenchon
Copy link
Member

Our soilCO2 model is a combination of these two papers:
https://onlinelibrary.wiley.com/doi/abs/10.1111/j.1365-2486.2011.02546.x
for the co2 production model
and https://gmd.copernicus.org/articles/11/1909/2018/ for the diffusion model
they provide example of values for the parameters, we could pick any for the default... note that they are not in SI and need to be converted.
Happy to help more!

@nefrathenrici
Copy link
Member Author

Thank you @AlexisRenchon !

@nefrathenrici nefrathenrici marked this pull request as ready for review March 8, 2024 22:12
Copy link
Member

@AlexisRenchon AlexisRenchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nat,
The PR looks good... is there anything in particular I should look at?

@nefrathenrici
Copy link
Member Author

Hi Nat, The PR looks good... is there anything in particular I should look at?

Are these defaults correct?

@AlexisRenchon
Copy link
Member

Yes the defaults are correct!
Maybe for porosity we could just say 0.5, if we do need a default (porosity of the soil is going to be different everywhere so it's a bit weird to have a very specific default)

@nefrathenrici nefrathenrici merged commit 8152587 into main Mar 19, 2024
10 checks passed
@juliasloan25 juliasloan25 deleted the ne/soilco2_params branch March 21, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants