remove HydrologyEarthParameters struct #982
Open
+28
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/inference
branch
from
9f09ffb to
debeb3b
Compare
|
What a mysterious bug! I thought it was from broadcasting over too many structs, but here it seems like we passed another as an argument, and it fixes it |
Unfortunately I don't think we fixed it, it looks like the most recent buildkite has the same error that we were seeing originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes the
HydrologyEarthParametersstruct, which was introduced in #739 to fix a GPU inference issue. Here, we instead update the interface ofphase_change_sourceto take in the full model parameters as its final argument. This both fixes the inference issue we saw before, and removes the allocating use ofHydrologyEarthParameters.closes #975