Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single column SlabSeaIceModel with flexible air-ice and water-ice boundary conditions #14

Merged
merged 20 commits into from
Sep 1, 2023

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Aug 24, 2023

This PR (will) implement a simple example using a zero heat capacity ice model.

Closes #15

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 5.91% and project coverage change: -40.18% ⚠️

Comparison is base (778779b) 66.99% compared to head (680f2cc) 26.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
- Coverage   66.99%   26.81%   -40.18%     
===========================================
  Files           2        7        +5     
  Lines         103      261      +158     
===========================================
+ Hits           69       70        +1     
- Misses         34      191      +157     
Files Changed Coverage Δ
src/ClimaSeaIce.jl 6.66% <0.00%> (-93.34%) ⬇️
src/SlabSeaIceModels.jl 0.00% <0.00%> (ø)
...ryConditions/bottom_thermal_boundary_conditions.jl 0.00% <0.00%> (ø)
src/ThermalBoundaryConditions/boundary_fluxes.jl 0.00% <0.00%> (ø)
...ndaryConditions/top_thermal_boundary_conditions.jl 0.00% <0.00%> (ø)
src/EnthalpyMethodSeaIceModels.jl 66.66% <81.81%> (ø)
...malBoundaryConditions/ThermalBoundaryConditions.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glwagner glwagner changed the title Single column zero heat capacity ice model Single column SlabSeaIceModel with flexible air-ice and water-ice boundary conditions Aug 30, 2023
@glwagner glwagner requested a review from jlk9 August 31, 2023 22:56
@glwagner
Copy link
Member Author

@jlk9 @simone-silvestri @navidcy this is ready for review.

I think we should wait on tests because the user API will continue to rapidly evolve.

Ideas for the next few PRs:

  • idealized coupled ice-ocean column
  • examples in docs
  • forcing by fluxes from ECCO time-series with prescribed ocean

@glwagner glwagner merged commit d9cc1da into main Sep 1, 2023
6 of 8 checks passed
@glwagner glwagner deleted the glw/zero-capacity-single-column branch September 1, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SlabSeaIceModel with radiation and turbulent boundary conditions
3 participants