-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a momentum equation and advection to the SlabSeaIceModel #24
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 22.80% 17.79% -5.01%
==========================================
Files 11 14 +3
Lines 307 399 +92
==========================================
+ Hits 70 71 +1
- Misses 237 328 +91 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want momentum equation implemented indepednent of whether we are using the slab model or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, in general each model will provide a 1D thickness and 1D concentration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we need an interface like
function ice_thickness end
which each model has to define, for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and please remember there is also a snow thickness. The interface cannot simply be "thickness"
This PR includes some changes, in particular
Still an ongoing work subjected to change
in collaboration with @jm-c