Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a momentum equation and advection to the SlabSeaIceModel #24

Open
wants to merge 71 commits into
base: main
Choose a base branch
from

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Dec 19, 2023

This PR includes some changes, in particular

  • advection of tracers and ice thickness/concentration using a prognostic sea-ice velocity
  • adams-bashforth timestepper for the SlabSeaIceModel
  • A growth parameterization for the ice concentration

Still an ongoing work subjected to change

in collaboration with @jm-c

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: Patch coverage is 0.76336% with 130 lines in your changes missing coverage. Please review.

Project coverage is 17.79%. Comparing base (5c39b77) to head (2a701dc).
Report is 3 commits behind head on main.

Current head 2a701dc differs from pull request most recent head f3d211c

Please upload reports for the commit f3d211c to get more accurate results.

Files Patch % Lines
src/SlabSeaIceModels/slab_time_stepping.jl 0.00% 51 Missing ⚠️
...SlabSeaIceModels/slab_tendency_kernel_functions.jl 0.00% 32 Missing ⚠️
src/SlabSeaIceModels/slab_sea_ice_model.jl 0.00% 21 Missing ⚠️
src/SlabSeaIceModels/thickness_advection.jl 0.00% 14 Missing ⚠️
...eaIceModels/SlabSeaIceDynamics/nothing_dynamics.jl 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   22.80%   17.79%   -5.01%     
==========================================
  Files          11       14       +3     
  Lines         307      399      +92     
==========================================
+ Hits           70       71       +1     
- Misses        237      328      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri simone-silvestri marked this pull request as ready for review June 26, 2024 14:19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want momentum equation implemented indepednent of whether we are using the slab model or not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, in general each model will provide a 1D thickness and 1D concentration?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we need an interface like

function ice_thickness end

which each model has to define, for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please remember there is also a snow thickness. The interface cannot simply be "thickness"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants