-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNKI doc source and edits #416
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example comment
docs/make.jl
Outdated
@@ -77,6 +77,7 @@ pages = [ | |||
"Examples" => examples, | |||
"List of default configurations" => "defaults.md", | |||
"Ensemble Kalman Inversion" => "ensemble_kalman_inversion.md", | |||
"Gauss Newton Kalman Inversion" => "gauss_newton_kalman_inversion.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example review
63f7f53
to
f04e8f4
Compare
f04e8f4
to
af546b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rgjini here are a few small comments to help!
…es.jl into rg/GNKI-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! after the small change
## Creating the EKI Object | ||
|
||
We first build a prior distribution (for details of the construction see [here](@ref constrained-gaussian)). | ||
Then we build our EKP object with `EnsembleKalmanProcess(args..., GaussNewtonInversion(prior); kwargs...)`. For general EKP object creation requirements see [Creating the EKI object](@ref eki). To make updates using the inversion algorithm see [Updating the Ensemble](@ref eki). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use triple quotes (without spaces) to get this to be a code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting is all set! I also included a couple minor changes that Matti suggested, so everything should be ready to merge! Maybe you could review it one last time before I merge?
Purpose
Closes #415
To-do
Content