Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Oceananigans compat #330

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Update Oceananigans compat #330

wants to merge 26 commits into from

Conversation

glwagner
Copy link
Member

No description provided.

@adelinehillier
Copy link
Collaborator

I'm baffled by the compilation errors here.

@glwagner
Copy link
Member Author

glwagner commented Apr 2, 2024

Hi @adelinehillier !

I think at least one issue in precompilation is a problem with an Optim extension:

https://github.com/CliMA/ParameterEstimocean.jl/actions/runs/8402936679/job/23012878959?pr=330#step:6:581

But this might not be our main dragon. I think the other problems come from trying to deserialize / load a saved type from a prior version of Oceananigans... which can fail when the properties of the type change :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants