-
Notifications
You must be signed in to change notification settings - Fork 616
Update cloud version matrix (25.10) #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kavirajk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 looks like some settings are failing in 25.10.
|
I'm taking a look at the failures. |
|
Hmm. I think something changed in In 25.9 But in 25.10 (looks like still 404, but body is missing the excpetion message?) For the same code. I'm investigating more to narrow down. Looks like something related to compression |
|
Hmm. Ok. I think found the root cause. tldr; it is caused by Some background and my previous assumption:In Go client. Unless user explicitly set If the compression is
If the compression is
There is one subtle misunderstanding in my above assumption. Even if user doesn't set any compression explicitly, Go standard library try to use So basically what's changed?Before 25.10 -> CH server ignores this After 25.10 -> CH server aware of this Reason for test case failure on this PRAnd test case is failing because, when CH send exception message on HTTP body (with double compressed 1. |
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
|
@SpencerTorres @jkaflik can I have some extra eyes on this comment and this commit of this PR? |
| IdleConnTimeout: opt.ConnMaxLifetime, | ||
| ResponseHeaderTimeout: opt.ReadTimeout, | ||
| TLSClientConfig: opt.TLS, | ||
| DisableCompression: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given enable_http_compression is default in CH since 25.10. I would rather Go driver control the HTTP header (Accept-Encoding) fully instead of some magic happening behind Go standard library. That's the rationale of it.
Update versions