add pk to tests

Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
ClickHouse · Nov 3, 2024 · 90ba920 · 90ba920
1 parent ae8a7b6
commit 90ba920
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/tests/integration/adapter/basic/test_incremental.py b/tests/integration/adapter/basic/test_incremental.py
@@ -7,7 +7,7 @@ class TestIncremental(BaseIncremental):
 
 
 incremental_not_schema_change_sql = """
-{{ config(materialized="incremental", unique_key="user_id_current_time",on_schema_change="append_new_columns") }}
+{{ config(materialized="incremental", primary_key="user_id_current_time", unique_key="user_id_current_time",on_schema_change="append_new_columns") }}
 select
     toString(1) || '-' || toString(now64()) as user_id_current_time,
     {% if is_incremental() %}

diff --git a/tests/integration/adapter/clickhouse/test_clickhouse_s3.py b/tests/integration/adapter/clickhouse/test_clickhouse_s3.py
@@ -36,6 +36,7 @@
     materialized='incremental',
     order_by='pickup_datetime',
     incremental_strategy='delete+insert',
+    primary_key='trip_id',
     unique_key='trip_id',
     taxi_s3={"structure":['trip_id UInt32', 'pickup_datetime DateTime', 'passenger_count UInt8']}
     )

diff --git a/tests/integration/adapter/incremental/test_base_incremental.py b/tests/integration/adapter/incremental/test_base_incremental.py
@@ -20,6 +20,7 @@
         materialized='table',
         engine='MergeTree()',
         order_by=['ts'],
+        primary_key=['impid'],
         unique_key=['impid']
     )
 }}
@@ -33,6 +34,7 @@
         materialized='incremental',
         engine='MergeTree()',
         order_by=['ts'],
+        primary_key=['impid'],
         unique_key=['impid'],
         settings={'allow_nullable_key':'1'}
     )
@@ -62,6 +64,7 @@ def test_simple_incremental(self, project):
 {{ config(
         materialized='incremental',
         order_by=['key1'],
+        primary_key='key1',
         unique_key='key1',
         incremental_strategy='delete+insert',
         settings={'allow_nullable_key':1}
@@ -97,6 +100,7 @@ def test_lw_delete(self, project):
 {{ config(
         materialized='incremental',
         order_by=['key1'],
+        primary_key='key1',
         unique_key='key1',
         incremental_strategy='legacy',
         settings={'allow_nullable_key':1}
@@ -140,6 +144,7 @@ def test_legacy(self, project):
 {{ config(
         materialized='incremental',
         order_by=['key1', 'key2'],
+        primary_key=['key1', 'key2'],
         unique_key='key1, key2',
         incremental_strategy='delete+insert'
     )
@@ -174,7 +179,7 @@ class TestInsertsOnlyIncrementalMaterialization(BaseIncremental):
     @pytest.fixture(scope="class")
     def models(self):
         config_materialized_incremental = """
-          {{ config(order_by='(some_date, id, name)', inserts_only=True, materialized='incremental', unique_key='id') }}
+          {{ config(order_by='(some_date, id, name)', inserts_only=True, materialized='incremental', primary_key='id', unique_key='id') }}
         """
         incremental_sql = config_materialized_incremental + model_incremental
         return {

diff --git a/tests/integration/adapter/incremental/test_distributed_incremental.py b/tests/integration/adapter/incremental/test_distributed_incremental.py
@@ -17,6 +17,7 @@
         materialized='distributed_table',
         engine='MergeTree()',
         order_by=['ts'],
+        primary_key=['impid'],
         unique_key=['impid']
     )
 }}
@@ -29,6 +30,7 @@
     config(
         materialized='distributed_incremental',
         engine='MergeTree()',
+        primary_key=['impid'],
         order_by=['ts'],
         unique_key=['impid']
     )
@@ -69,6 +71,7 @@ def test_simple_incremental(self, project):
 {{ config(
         materialized='distributed_incremental',
         order_by=['key1'],
+        primary_key='key1',
         unique_key='key1',
         incremental_strategy='delete+insert'
     )
@@ -111,6 +114,7 @@ def test_lw_delete(self, project):
 {{ config(
         materialized='distributed_incremental',
         order_by=['key1', 'key2'],
+        primary_key=['key1', 'key2'],
         unique_key='key1, key2',
         incremental_strategy='delete+insert'
     )
@@ -158,7 +162,7 @@ class TestInsertsOnlyDistributedIncrementalMaterialization(BaseIncremental):
     @pytest.fixture(scope="class")
     def models(self):
         config_materialized_incremental = """
-          {{ config(order_by='(some_date, id, name)', inserts_only=True, materialized='distributed_incremental', unique_key='id') }}
+          {{ config(order_by='(some_date, id, name)', inserts_only=True, materialized='distributed_incremental', primary_key='id', unique_key='id') }}
         """
         incremental_sql = config_materialized_incremental + model_incremental
         return {
@@ -182,7 +186,7 @@ def test_incremental(self, project):
 
 
 incremental_not_schema_change_sql = """
-{{ config(materialized="distributed_incremental", unique_key="user_id_current_time",on_schema_change="sync_all_columns") }}
+{{ config(materialized="distributed_incremental", primary_key="user_id_current_time", unique_key="user_id_current_time", on_schema_change="sync_all_columns") }}
 select
     toString(1) || '-' || toString(now64()) as user_id_current_time,
     {% if is_incremental() %}

diff --git a/tests/integration/adapter/incremental/test_schema_change.py b/tests/integration/adapter/incremental/test_schema_change.py
@@ -8,6 +8,7 @@
 {{
     config(
         materialized='%s',
+        primary_key='col_1',
         unique_key='col_1',
         on_schema_change='%s'
     )
@@ -101,6 +102,7 @@ def test_append(self, project, model):
 {{
     config(
         materialized='%s',
+        primary_key='col_1',
         unique_key='col_1',
         on_schema_change='%s'
     )
@@ -189,6 +191,7 @@ def test_sync(self, project, model):
 {{
     config(
         materialized='%s',
+        primary_key='col_1',
         unique_key='col_1',
         on_schema_change='fail'
     )