-
Couldn't load subscription status.
- Fork 1
Adjust sink version #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mzitnik could you fix the tests? |
| <dependency> | ||
| <groupId>com.clickhouse.flink</groupId> | ||
| <artifactId>flink-connector-clickhouse-1.17</artifactId> | ||
| <version>0.0.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzitnik can we start with 0.1.0 as we did for kafka connect sink? https://github.com/ClickHouse/clickhouse-kafka-connect/releases?page=4
I'm not comfortable with 1.0.0 since we might need to introduce breaking changes based on the initial feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshustov
In Kafka Connect, we started with 0.0.1 https://github.com/ClickHouse/clickhouse-kafka-connect/releases/tag/v0.0.1-alfa
Looking at this, I was thinking maybe the DataStream we use 1.0.0 And when we develop the Table API, we will use 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzitnik I know, 0.0.1 just looks like an alpha or beta version, which might look scary, so I'd prefer 0.1.0 to re-assure the customers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to merge and publish when the version is changed to 0.1.0
Summary
Closes #41
Checklist
Delete items not relevant to your PR: