Skip to content

Conversation

@mzitnik
Copy link
Contributor

@mzitnik mzitnik commented Sep 1, 2025

Summary

Closes #41

Checklist

Delete items not relevant to your PR:

@mshustov
Copy link
Member

mshustov commented Sep 1, 2025

@mzitnik could you fix the tests?

<dependency>
<groupId>com.clickhouse.flink</groupId>
<artifactId>flink-connector-clickhouse-1.17</artifactId>
<version>0.0.1</version>
Copy link
Member

@mshustov mshustov Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzitnik can we start with 0.1.0 as we did for kafka connect sink? https://github.com/ClickHouse/clickhouse-kafka-connect/releases?page=4
I'm not comfortable with 1.0.0 since we might need to introduce breaking changes based on the initial feedback

Copy link
Contributor Author

@mzitnik mzitnik Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshustov
In Kafka Connect, we started with 0.0.1 https://github.com/ClickHouse/clickhouse-kafka-connect/releases/tag/v0.0.1-alfa
Looking at this, I was thinking maybe the DataStream we use 1.0.0 And when we develop the Table API, we will use 2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzitnik I know, 0.0.1 just looks like an alpha or beta version, which might look scary, so I'd prefer 0.1.0 to re-assure the customers

Copy link
Member

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge and publish when the version is changed to 0.1.0

@mzitnik mzitnik merged commit c91541f into main Sep 1, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust Version before first release

2 participants