Update from 2.0.2 to 2.1.6 #16

al13n321 · 2024-05-27T21:43:17Z

To fix ClickHouse/ClickHouse#63319 (just updating to latest version, didn't look for the exact commit that fixed it)

make sure input/output args match original functions from clang/gcc

* Ubuntu 22.04 use different format for ABI files so old ones need to be removed * Use more recent zlib-ng commit to avoid issues with internal adler32 and crc32 functions

* Add detection of XSAVE intrinsics

…fileops is specified.

* Disable visibility check for Cygwin, MinGW and MSYS as the compiler will only issue warning instead of error for unsupported attributes.

A fixed block could be chosen when a stored block was smaller. Now the smaller of the two is always chosen.

memLevel 9 would cause deflateBound() to assume the use of fixed blocks, even if the compression level was 0, which forces stored blocks. That could result in a bound less than the size of the compressed data. Now level 0 always uses the stored blocks bound.

gzsetparams() now returns a Z_STREAM_ERROR in this case.

`functable` is already declared by functable.h which is included by functable.c

…mark#1454. Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

This should reduce the cost of indirection that occurs when calling functable chunk copying functions inside inflate_fast. It should also allow the compiler to optimize the inflate fast path for the specific architecture.

…tations. Added debug assert check for value = 0. Added more details to the comment to avoid future confusion. Added fallback logic for older MSVC versions, just in case.

… pointers from functable Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

…ons of -march=native.

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

This requires minimum CMake 3.5 and C++11, this matches nicely with zlib-ng 2.1.x requirements.

Makefiles require using tabs as indents. So we need to remove this rule.

…Lists.txt, hope I got everything right)

CLAassistant · 2024-05-27T21:43:32Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 14 committers have signed the CLA.

✅ al13n321
❌ Xeonacid
❌ mtl1979
❌ bebuch
❌ autoantwort
❌ Dead2
❌ yosh-matsuda
❌ phprus
❌ nmoinvaz
❌ KungFuJesus
❌ FantasqueX
❌ ccawley2011
❌ RyeMutt
❌ uilianries
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

al13n321 · 2024-06-20T22:58:29Z

#17

ccawley2011 and others added 30 commits January 22, 2023 00:58

Fix MSVC warnings in benchmark code

41a5e00

Match __builtin_ctzl/__builtin_ctzll signatures

147dd9f

make sure input/output args match original functions from clang/gcc

Fix ABI checking...

750a7a0

* Ubuntu 22.04 use different format for ABI files so old ones need to be removed * Use more recent zlib-ng commit to avoid issues with internal adler32 and crc32 functions

Fix typo found by codespell

9119de0

Add temporary cmake build dirs/files to gitignore

cba1a78

Add assert for tzcnt if building with X86_NOCHECK_TZCNT

78d5883

Fix MinGW build

b892331

* Add detection of XSAVE intrinsics

Fix configure to use correct linker definition file when --without-gz…

b48750d

…fileops is specified.

Add support for symbol prefix to linker definition files.

5ff2b9b

Fix building resource files during out-of-tree build with configure

1cb12dc

Fix missing gzip functions when linking example and minigzip binaries.

bfbbea7

Allow disabling visibility attribute with configure

a02ba01

* Disable visibility check for Cygwin, MinGW and MSYS as the compiler will only issue warning instead of error for unsupported attributes.

Have build test report library version if it doesn't match zlib.h.

24d7d0d

Have infback() deliver all of the available output up to any error.

6581fb0

Fix bug in block type selection when Z_FIXED used.

5393c21

A fixed block could be chosen when a stored block was smaller. Now the smaller of the two is always chosen.

Add WIN32_LEAN_AND_MEAN for windows.h include.

0e49aa3

Remove -pedantic from configure -w compile options.

c671129

Remove redundant check in gz_look().

33e671b

Fix crash when gzsetparams() attempted for transparent write.

e713f2f

gzsetparams() now returns a Z_STREAM_ERROR in this case.

Sync with zlib 1.2.13 and declare compatibility.

d5db5aa

Avoid functable redefinition in functable.c

fecb03a

`functable` is already declared by functable.h which is included by functable.c

Move initialization of functable to init_functable function

df60007

Use local functable variable instead of standalone function pointers

709a710

Rename local functable variable to ft

d144fc0

Pin Google Benchmark to v1.7.1 to fix the upstream issue google/bench…

941ce54

…mark#1454. Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

Use arch-specific versions of inflate_fast.

aa1109b

This should reduce the cost of indirection that occurs when calling functable chunk copying functions inside inflate_fast. It should also allow the compiler to optimize the inflate fast path for the specific architecture.

Remove unused chunk memory functions from functable.

c72cd30

Replace __builtin_ctz[ll] fallback functions with branchless implemen…

1733143

…tations. Added debug assert check for value = 0. Added more details to the comment to avoid future confusion. Added fallback logic for older MSVC versions, just in case.

Remove FORCE_TZCNT/X86_NOCHECK_TZCNT

17d9807

phprus and others added 25 commits December 21, 2023 16:12

Add force initialization functable, because deflate captures function…

0c32ad4

… pointers from functable Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

Initialize functable earlier, during inflateInit

ba4a781

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

Improve performance of crc32_acle on 32-bit ARM

a0356fa

Check if compiler supports -march=native or -mcpu=native.

0756ec4

Always run CMake tests without LTO.

0b080ed

Add support for __attribute__((__target__(...))) to overcome limitati…

4ece1a4

…ons of -march=native.

Make sure uqsub16 mnemonic doesn't get optimized away.

b7fc54e

Atomic functable

9d486b5

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

Remove unused Z_TLS and HAVE_THREAD_LOCAL

dfced56

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>

Update to GoogleTest 1.12.1.

2f1747a

This requires minimum CMake 3.5 and C++11, this matches nicely with zlib-ng 2.1.x requirements.

Add status output when running git checkout of GoogleTest

8fbff4b

Don't incorrectly disable GoogleTest because of old CMake version.

4799b1a

Don't attempt ARMv6 detection on AARCH64.

0993a7e

Add linter workflow for whitespace errors. zlib-ng#1190

758212b

Fix trailing whitespace in minideflate.c.

bed309d

Fixed tab character in ARM ACLE uqsub16 assembly.

41dd22b

Fix memory corruption introduced in 61e181c

a61926d

Cancel previously running CI jobs for PR or branch.

fd5b20f

Remove tab-in-indent rule from lint workflow

838a5d5

Makefiles require using tabs as indents. So we need to remove this rule.

Added CI instance for WITH_NATIVE_INSTRUCTIONS.

f8327aa

Add FAR macro to zlib-compat headers to improve compatibility.

89c932b

Fix building tests with cmake 3.10 and older.

9053e43

2.1.6 Release

7425372

Merge commit '7425372' (zlib-ng release 2.1.6) into HEAD

2c4300b

Resolve conflicts (reproduce the ((constructor)) change, update CMake…

bfb184b

…Lists.txt, hope I got everything right)

al13n321 mentioned this pull request May 27, 2024

Update zlib-ng from 2.0.2 to 2.1.7 ClickHouse/ClickHouse#64489

Merged

al13n321 marked this pull request as ready for review May 28, 2024 19:02

al13n321 closed this Jun 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update from 2.0.2 to 2.1.6 #16

Update from 2.0.2 to 2.1.6 #16

al13n321 commented May 27, 2024

CLAassistant commented May 27, 2024 •

edited

Loading

al13n321 commented Jun 20, 2024

Update from 2.0.2 to 2.1.6 #16

Update from 2.0.2 to 2.1.6 #16

Conversation

al13n321 commented May 27, 2024

CLAassistant commented May 27, 2024 • edited Loading

al13n321 commented Jun 20, 2024

CLAassistant commented May 27, 2024 •

edited

Loading