Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same-Day Archived Files to PDC Cannot Be Distinguished #3857

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Same-Day Archived Files to PDC Cannot Be Distinguished #3857

wants to merge 6 commits into from

Conversation

RasmusBurge-CG
Copy link
Contributor

@RasmusBurge-CG RasmusBurge-CG commented Oct 17, 2024 •
edited
Loading

Description

Added

  • A flag "-ifnewer" to the retrieval command.

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@RasmusBurge-CG RasmusBurge-CG linked an issue Oct 17, 2024 that may be closed by this pull request
Same file archived to PDC the same day cannot be destinguished #3843
Open
1 task
@RasmusBurge-CG RasmusBurge-CG marked this pull request as ready for review October 17, 2024 08:33
@RasmusBurge-CG RasmusBurge-CG requested a review from a team as a code owner October 17, 2024 08:33
ChrOertlin
ChrOertlin approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

diitaz93
diitaz93 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

@ChrOertlin ChrOertlin ChrOertlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Same file archived to PDC the same day cannot be destinguished
3 participants
@RasmusBurge-CG @ChrOertlin @diitaz93