Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balsamic-qc): Remove #3924

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(balsamic-qc): Remove #3924

wants to merge 7 commits into from

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Nov 7, 2024

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@henrikstranneheim henrikstranneheim requested a review from a team as a code owner November 7, 2024 08:38
@henrikstranneheim henrikstranneheim mentioned this pull request Nov 7, 2024
2 tasks
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! We have not refined the whole issue yet though so I am a bit hesitant to comment on everything. I think we have not said with 100% certainty what happens with the internal cases which we already have with this workflow, for example. We will probably need to sync any changes with quite some repositories (systemd changes in servers, potential workflow changes in Trailblazer, new orderform without the balsamic-qc option etc). Nice work though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants