Fix RNA uploads/delivery message draft #4145
Conversation
| dna_samples_cases_analysis_query: Query = ( | ||
| sample_query.join(Sample.links).join(CaseSample.case).join(Analysis) | ||
| ) |
There was a problem hiding this comment.
I understand that we difenie these queries in cg/store/base.py. Also,maybe this function can be used instead _get_join_analysis_sample_family_query?
There was a problem hiding this comment.
I do think BSV fought with this quite a bit in her PR and it might be that the behaviour was slightly different. Given that this is not something I have written, I would prefer not changing it.
There was a problem hiding this comment.
still defining it in base would enhance reusability and avoid code duplication
There was a problem hiding this comment.
But none of them add to an already existing query? Why should it be there?
|
|
Upload linking works ✅ [isak.ohlsson@hasta:2025-01-29] [S_base] $ cg upload rna-junctions-to-scout --dry-run sharpbulldog |
Description
Closes #4115. The main change is that we filter on the RNA case's collaborators, rather than its samples' but it also merges the logic in the upload flow and the delivery message flow, where different parts of the code was used to link the RNA case to its DNA cases.
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan