Avoid uvicorn logger and use __main__ logger and remove logger from multiprocessing code #320
Conversation
| import subprocess | ||
| from multiprocessing import Manager, Pool | ||
| from typing import Dict, List, Tuple | ||
|
|
||
| LOG = logging.getLogger("uvicorn.access") |
There was a problem hiding this comment.
This wasn't used anyway
northwestwitch
changed the title
|
| @@ -28,6 +30,7 @@ def create_db_and_tables(): | |||
|
|
|||
| @asynccontextmanager | |||
| async def lifespan(app_: FastAPI): | |||
| configure_log() | |||
There was a problem hiding this comment.
Call a function that configures the log before doing the logging
|
Nice! I'll see if I can reproduce the error locally. Otherwise I could perhaps put it on our server and we'll know next week (or after the vacation :) ). |
Exactly! ;) |
|
I didn't manage to reproduce the issue on my laptop, so testing on the server it is! Would it be fine to merge the latest master into this PR? Then I could production-test the d4tools update as well. |
The d4tools fix is merged in this branch. So it should be fine to test |
|
I'm merging this PR seems it seems to work (tested on our dev server). Let's see how it goes after next weekend 🤞🏻 |
Description
Added/Changed/Fixed
How to test
Expected outcome
Review
This version is a