Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starlette.templating deprecation warning #333

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Aug 2, 2024

Description

Fixed

How to test

  • Automatic test

Expected outcome

  • Demo report should be visible when app is deployed locally

Review

  • Tests executed by GitHub actions, CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link

sonarqubecloud bot commented Aug 2, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (4c8ac1b) to head (928003a).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   94.40%   94.52%   +0.11%     
==========================================
  Files          35       36       +1     
  Lines        2002     2044      +42     
==========================================
+ Hits         1890     1932      +42     
  Misses        112      112              
Flag Coverage Δ
unittests 94.52% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

Demo report and demo overview pages still work fine:

image image

@northwestwitch northwestwitch merged commit a0002bc into main Aug 2, 2024
7 checks passed
@northwestwitch northwestwitch deleted the fix_starlette_templating_warning branch August 2, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The name is not the first parameter anymore. The first parameter should be the Request instance.
2 participants