Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor report/overview code so coverage completeness is obtained directly from d4tools #340

Closed
wants to merge 7 commits into from

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Aug 15, 2024

OBS: this PR can be merged only after d4tools contains the new "perc_cov" option in the stats command line, so I'm marking it as a draft

Description

Added/Changed/Fixed

How to test

  • Deploy on stage and compare the coverage report from a scout case with coverage report obtained using main branch
  • Compare also the genes overview using the same scout case

Expected outcome

  • Numbers should be comparable (not exactly the same, because the new function calculates the mean completeness as the mean of all coverage completeness over all intervals. These numbers are collected from the d4tools output

Review

  • Tests executed by
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch changed the title Refactor code for coverage report so completeness is obtained directly from d4tools Refactor code so coverage completeness is obtained directly from d4tools Aug 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 36 lines in your changes missing coverage. Please review.

Project coverage is 89.66%. Comparing base (719f1b8) to head (153df0a).
Report is 11 commits behind head on main.

Files Patch % Lines
src/chanjo2/meta/handle_d4.py 7.89% 35 Missing ⚠️
src/chanjo2/meta/handle_report_contents.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   90.18%   89.66%   -0.52%     
==========================================
  Files          30       30              
  Lines        1457     1481      +24     
==========================================
+ Hits         1314     1328      +14     
- Misses        143      153      +10     
Flag Coverage Δ
unittests 89.66% <7.69%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch changed the title Refactor code so coverage completeness is obtained directly from d4tools Refactor report/overview code so coverage completeness is obtained directly from d4tools Aug 16, 2024
@northwestwitch northwestwitch added Enhancement New feature or request Refactor labels Aug 16, 2024
Copy link

@northwestwitch
Copy link
Member Author

To avoid errors I'm going to simplify and change the code of the completeness multitasker to code that uses the new perc_cov d4tools function. Closing this PR

@northwestwitch northwestwitch deleted the refactor_completeness branch October 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants