Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANE transcripts report #365

Merged
merged 17 commits into from
Oct 7, 2024
Merged

MANE transcripts report #365

merged 17 commits into from
Oct 7, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Oct 4, 2024

Description

Added/Changed/Fixed

image

How to test

Expected outcome

  • MANE reports should be created using the new endpoint

Review

  • Tests executed by Jakob37, CR
  • "Merge and deploy" approved by Jakob37

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 78.18182% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (719f1b8) to head (106844c).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
src/chanjo2/meta/handle_report_contents.py 60.00% 10 Missing ⚠️
src/chanjo2/endpoints/overview.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   90.18%   93.13%   +2.95%     
==========================================
  Files          30       31       +1     
  Lines        1457     1501      +44     
==========================================
+ Hits         1314     1398      +84     
+ Misses        143      103      -40     
Flag Coverage Δ
unittests 93.13% <78.18%> (+2.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch marked this pull request as ready for review October 7, 2024 08:46
@northwestwitch
Copy link
Member Author

northwestwitch commented Oct 7, 2024

This one is ready for review now, but I realise that it might be hard to test without also a PR in scout.. I'll work on that as well!

@northwestwitch northwestwitch requested a review from Jakob37 October 7, 2024 16:00
Copy link
Collaborator

@Jakob37 Jakob37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks 😄 Testing worked well, and only minimal comments on the code.

Looking forward to hear our geneticists thoughts on this. I think it will very helpful for them.

src/chanjo2/templates/mane-overview.html Outdated Show resolved Hide resolved
<tr>
<td class="row">
<div class="panel-default">
<div class="panel-heading">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code identations seems off here and below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK on the editor though, weird!

image

I think I'll leave it as it is

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be mixed tabs and spaces? (Anyway, not a big issue)

Co-authored-by: Jakob Willforss <Jakob37@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Oct 7, 2024

@northwestwitch
Copy link
Member Author

Looking forward to hear our geneticists thoughts on this. I think it will very helpful for them.

Cool, thanks for the review. Let me know how it goes! Merging now!

@northwestwitch northwestwitch merged commit 6aa3200 into main Oct 7, 2024
7 checks passed
@northwestwitch northwestwitch deleted the show_mane_stats branch October 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MANE transcripts
3 participants