-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANE transcripts report #365
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 90.18% 93.13% +2.95%
==========================================
Files 30 31 +1
Lines 1457 1501 +44
==========================================
+ Hits 1314 1398 +84
+ Misses 143 103 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This one is ready for review now, but I realise that it might be hard to test without also a PR in scout.. I'll work on that as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks 😄 Testing worked well, and only minimal comments on the code.
Looking forward to hear our geneticists thoughts on this. I think it will very helpful for them.
<tr> | ||
<td class="row"> | ||
<div class="panel-default"> | ||
<div class="panel-heading"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code identations seems off here and below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be mixed tabs and spaces? (Anyway, not a big issue)
Co-authored-by: Jakob Willforss <Jakob37@users.noreply.github.com>
Quality Gate passedIssues Measures |
Cool, thanks for the review. Let me know how it goes! Merging now! |
Description
Added/Changed/Fixed
How to test
Expected outcome
Review
This version is a