-
Notifications
You must be signed in to change notification settings - Fork 0
Save Ensembl transcript ID and exon number in exons table #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 90.18% 93.15% +2.96%
==========================================
Files 30 31 +1
Lines 1457 1504 +47
==========================================
+ Hits 1314 1401 +87
+ Misses 143 103 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Since I'm touching the code I think I'll also add the |
Tested locally and it works, see screesnhot in comment above |
|
@@ -104,6 +104,7 @@ class ExonBase(IntervalBase): | |||
ensembl_id: str | |||
ensembl_gene_id: str | |||
ensembl_transcript_id: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pydantic model already contained this field, so I think I I meant to include it at some point, but forgot to update the SQLAlchemy exon model
Description
Added/Changed/Fixed
exons table before:
exons table after:
How to test
Expected outcome
Review
This version is a