Skip to content

Save Ensembl transcript ID and exon number in exons table #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Oct 9, 2024

Description

Added/Changed/Fixed

exons table before:

image

exons table after:

image

How to test

  • Locally, drop and re-create the sql database
  • Load genes, transcripts and exons
  • Check the exons table

Expected outcome

  • It should contain the ensembl_transcript_id field

Review

  • Tests executed by CR
  • "Merge and deploy" approved by

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch changed the title Load transcripts exons Save Ensembl transcript ID field in exons table Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (719f1b8) to head (4d2242f).
Report is 101 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   90.18%   93.15%   +2.96%     
==========================================
  Files          30       31       +1     
  Lines        1457     1504      +47     
==========================================
+ Hits         1314     1401      +87     
+ Misses        143      103      -40     
Flag Coverage Δ
unittests 93.15% <100.00%> (+2.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

northwestwitch commented Oct 9, 2024

Since I'm touching the code I think I'll also add the exon number in transcript to the table

@northwestwitch northwestwitch changed the title Save Ensembl transcript ID field in exons table Save Ensembl transcript ID and exon number in exons table Oct 9, 2024
@northwestwitch
Copy link
Member Author

Tested locally and it works, see screesnhot in comment above

Copy link

sonarqubecloud bot commented Oct 9, 2024

@@ -104,6 +104,7 @@ class ExonBase(IntervalBase):
ensembl_id: str
ensembl_gene_id: str
ensembl_transcript_id: str
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pydantic model already contained this field, so I think I I meant to include it at some point, but forgot to update the SQLAlchemy exon model

@northwestwitch northwestwitch merged commit 786f508 into main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save transcript_id info and exon number in exons database documents
2 participants