Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close files #71

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Close files #71

merged 3 commits into from
Jan 24, 2024

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Jan 24, 2024

Some files are read without explicitly closing them, this PR ensures the files are closed.

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link
Collaborator

@rannick rannick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rannick rannick merged commit 3c959eb into master Jan 24, 2024
2 checks passed
@rannick rannick deleted the close-files branch January 24, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants