Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pubmlst utils #188

Merged
merged 38 commits into from
Dec 18, 2024
Merged

Add pubmlst utils #188

merged 38 commits into from
Dec 18, 2024

Conversation

ahdamin
Copy link
Contributor

@ahdamin ahdamin commented Dec 7, 2024

Description

The features of this PR primarily concerns bioinformaticians/internals

Summary of the changes made:

  • Add PubMLST utils to handle authenticated API calls
  • Update referecer to use PubMLST utils

Primary function of PR

  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Test routine to verify the stability of the PR:

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
  • us
  • conda activate S_microSALT
  • (SITUATIONAL) export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
  • Select a relevant subset of the following:
  • microSALT analyse project MIC3109
  • microSALT analyse project MIC4107
  • microSALT analyse project MIC4109
  • microSALT analyse project ACC5551

Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

@ahdamin ahdamin linked an issue Dec 7, 2024 that may be closed by this pull request
@karlnyr karlnyr changed the base branch from master to rc410 December 10, 2024 08:23
@ahdamin ahdamin self-assigned this Dec 10, 2024
@ahdamin ahdamin marked this pull request as ready for review December 17, 2024 07:10
@ahdamin ahdamin requested a review from a team as a code owner December 17, 2024 07:10
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diitaz93 diitaz93 merged commit 5decd55 into rc410 Dec 18, 2024
1 check passed
@diitaz93
Copy link

Deployed to stage and prod

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
repository is clean
Logging deploy ...
Getting deployer... done.
Getting last commit message and SHA... done.
Getting version of deploy scripts... /home/js.diazboada
done.
Log deploy... done.
microSALT, version 4.0.0
[js.diazboada@hasta:~] [P_base] $

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accomodate pubMLST authentication change
3 participants