Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Something happened in the revert of the rc410, this is just actually implementing the intended fixes that should be in place in master.
Primary function of PR
Testing
If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.
Test routine to verify the stability of the PR:
bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAMEusconda activate S_microSALTexport MICROSALT_CONFIG=/home/proj/dropbox/microSALT.jsonmicroSALT analyse project MIC3109microSALT analyse project MIC4107microSALT analyse project MIC4109microSALT analyse project ACC5551Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx
Test results
These are the results of the tests, and necessary conclusions, that prove the stability of the PR.
Sign-offs