Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tower workflow file interactions #489

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Remove tower workflow file interactions #489

merged 4 commits into from
Sep 11, 2024

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Aug 30, 2024

Blocked by https://github.com/Clinical-Genomics/IT-issues/issues/874 for production

I missed some instances where we still interact with the workflow file instead of using the workflow id stored in the database on the analysis.

Tested in stage, everything works.

Fixed

  • Swapped out old workflow file interactions when handling nf_tower analyses.

Steps to test

  1. Queue workflow run with cg workflow rnafusion start cuddlyhen in stage.
  2. Go to cigrid and cancel analysis
  3. Verify that the analysis is cancelled in tower as well https://cg-tower-stage.scilifelab.se
Screen.Recording.2024-08-30.at.14.27.57.mov

@seallard seallard marked this pull request as ready for review August 30, 2024 12:17
@seallard seallard requested a review from a team as a code owner August 30, 2024 12:17
@clingen-sthlm clingen-sthlm temporarily deployed to stage August 30, 2024 12:18 Inactive
Copy link

@diitaz93 diitaz93 assigned islean and unassigned diitaz93 Sep 11, 2024
@clingen-sthlm clingen-sthlm temporarily deployed to stage September 11, 2024 08:39 Inactive
@islean
Copy link
Contributor

islean commented Sep 11, 2024

Tested again:

image

After cancelling:

image

Cancelled in tower:

image

Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@islean islean merged commit 2c3a03c into master Sep 11, 2024
5 checks passed
@islean islean deleted the fix-cancel branch September 11, 2024 08:57
@islean
Copy link
Contributor

islean commented Sep 11, 2024

Deployed to the VMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants