Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_hidden parameter #490

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Add is_hidden parameter #490

merged 2 commits into from
Sep 4, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Sep 2, 2024

Description

Part of https://github.com/Clinical-Genomics/cigrid-ui/issues/493 and adds the option to hide a created analysis.

Added

  • Option to mark analysis as hidden upon creation.

Changed

Fixed

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b [THIS-BRANCH-NAME] -a
  • ssh to clinical-db (depending on type of change)
  • install on stage:
    bash /home/proj/production/servers/resources/clinical-db.scilifelab.se/update-trailblazer-ui-stage.sh [THIS-BRANCH-NAME]

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@islean islean requested a review from a team as a code owner September 2, 2024 14:11
Copy link

sonarqubecloud bot commented Sep 2, 2024

@clingen-sthlm clingen-sthlm temporarily deployed to stage September 4, 2024 09:36 Inactive
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just a small comment about the name, feel free to disregard

@islean islean merged commit 8a3281d into master Sep 4, 2024
5 checks passed
@islean islean deleted the add-is-hidden-parameter branch September 4, 2024 12:39
@islean
Copy link
Contributor Author

islean commented Sep 4, 2024

Deployed to the VMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants