Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pydantic): Warning #497

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(pydantic): Warning #497

merged 2 commits into from
Oct 1, 2024

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Oct 1, 2024 •
edited
Loading

Description

Added

Changed

Fixed

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage: 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b [THIS-BRANCH-NAME] -a
  • ssh to clinical-db (depending on type of change)
  • install on stage:
    bash /home/proj/production/servers/resources/clinical-db.scilifelab.se/update-trailblazer-ui-stage.sh [THIS-BRANCH-NAME]

How to test

  • login to ...
  • do ...

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@henrikstranneheim
Copy link
Contributor Author

henrikstranneheim commented Oct 1, 2024 •
edited
Loading

No warning, 👍

Screenshot 2024-10-01 at 09 29 18

@henrikstranneheim henrikstranneheim self-assigned this Oct 1, 2024
@henrikstranneheim henrikstranneheim marked this pull request as ready for review October 1, 2024 07:32
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner October 1, 2024 07:32
@henrikstranneheim henrikstranneheim linked an issue Oct 1, 2024 that may be closed by this pull request
Pydantic: UserWarning: A custom validator is returning a value other than self. #496
Closed
islean
islean approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@henrikstranneheim henrikstranneheim merged commit 615eafd into master Oct 1, 2024
5 checks passed
@henrikstranneheim henrikstranneheim deleted the fix-pydantic-warning branch October 1, 2024 08:47
@henrikstranneheim
Copy link
Contributor Author

Deployed to prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees

@henrikstranneheim henrikstranneheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pydantic: UserWarning: A custom validator is returning a value other than self.
2 participants
@henrikstranneheim @islean